Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft][Develop] Fix test_porxy integ test #6302

Open
wants to merge 21 commits into
base: develop
Choose a base branch
from

Conversation

hehe7318
Copy link
Contributor

@hehe7318 hehe7318 commented Jun 19, 2024

Description of changes

  • test_porxy integ test can not pass on Jenkin but can pass on local machine, suspect is because of SSH settings on Jenkins docker
  • Increase connection_timeout to fix paramiko: no existing session issue
  • Fix Proxy Stack deletion failed issue
  • For Paramiko : Error reading SSH protocol banner issue, tried below options:
    • Increase banner_timeout
    • Run ssh-agent -s and set the env variables, run ssh-add <private-key>
      • Modify run_command function, if env is not set, use os.environ
    • Enable inline_ssh_env for RemoteCommandExecutor, and add env_prefix before the commands
    • For now, this issue hasn't been fixed, once done will remove [Draft] label

Tests

  • test_porxy integ test can not pass on Jenkins
  • test_porxy integ test can pass on local machine

References

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…longer connection timeout to avoid paramiko.ssh_exception.SSHException: No existing session error.
…add set ssh environment variables logic. Split the ssh-agent and ssh-add commands and add log output to debug.
…Set it to False, to disable connecting to the SSH agent when using paramiko.
…env to pass env vairables. Add logic to show SSH keys added
@hehe7318 hehe7318 added skip-changelog-update Disables the check that enforces changelog updates in PRs 3.x labels Jun 19, 2024
@hehe7318 hehe7318 requested review from a team as code owners June 19, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x skip-changelog-update Disables the check that enforces changelog updates in PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant